Cache register names#458
Conversation
|
Sorry that two unrelated commits appear in the same PR. |
|
|
| // but for now we just retrieve them every time to keep it simple. | ||
| const names = await this.getRegisterNames(); | ||
| if (!this.regNames) { | ||
| this.regNames = await this.getRegisterNames(); |
There was a problem hiding this comment.
the idea is good, but we need to store the regnames per inferior (you may switch between multiple ones via UI), not globally, as the inferiors can have different registers (example: server in 64 bit and client in 32 bit (or vice versa), attached to both)
GitMensch
left a comment
GitMensch
left a comment
There was a problem hiding this comment.
please check the scope of the caching and add a ChangeLog entry as well (one for each commit, but I'm not convinced yet that the second commit should be merged - maybe focus on the register caching here and discuss dropping the setting [which also needs a ChangeLog entry] separately)
|
rest LGTM, just GitMensch's comment |
Please don't remove this functionality, it is not meaningless. I've used this for many years and others have as well. Was there some problem you were trying to solve by removing this? In the original PR thread (see here), I described how this works for an "attach" when used in combination with gdbserver where the application does not start running immediately. In that context it is valid to run the application to the entry point. |
|
Close this PR first. When I'm ready, I'll submit a new one. |
4 participants
Cache register names